HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41680 )
Change subject: soc/intel/xeon_sp: Early programming of ACPI bar ......................................................................
Patch Set 1:
(3 comments)
Please include only what you use
https://review.coreboot.org/c/coreboot/+/41680/1/src/soc/intel/xeon_sp/inclu... File src/soc/intel/xeon_sp/include/soc/bootblock.h:
https://review.coreboot.org/c/coreboot/+/41680/1/src/soc/intel/xeon_sp/inclu... PS1, Line 2: /* This file is part of the coreboot project. */ please remove
https://review.coreboot.org/c/coreboot/+/41680/1/src/soc/intel/xeon_sp/pch.c File src/soc/intel/xeon_sp/pch.c:
https://review.coreboot.org/c/coreboot/+/41680/1/src/soc/intel/xeon_sp/pch.c... PS1, Line 2: * This file is part of the coreboot project. */ Please remove
https://review.coreboot.org/c/coreboot/+/41680/1/src/soc/intel/xeon_sp/pch.c... PS1, Line 4: #include <device/pci_ops.h> : #include <device/device.h> : #include <device/pci_def.h> : #include <intelblocks/cse.h> : #include <intelblocks/fast_spi.h> : #include <intelblocks/itss.h> : #include <intelblocks/lpc_lib.h> : #include <intelblocks/p2sb.h> : #include <intelblocks/pcr.h> : #include <intelblocks/pmclib.h> : #include <intelblocks/rtc.h> : #include <soc/bootblock.h> : #include <soc/iomap.h> : #include <soc/p2sb.h> : #include <soc/pch.h> : #include <soc/pci_devs.h> : #include <soc/pcr_ids.h> : #include <soc/pm.h> : #include <soc/pmc.h> : #include "../chip.h" : #include <console/console.h> are you using all of them ?
Please clean-up.