[coreboot-gerrit] Change in ...coreboot[master]: google/kukui: Implement HW reset function

[Hung-Te Lin (Code Review)]

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31118 )

Change subject: google/kukui: Implement HW reset function
......................................................................

Patch Set 1:

(1 comment)

I think we should split this into few CLs:

1. Refactor wdt and move wdt_reset to reset.c (maybe add CONFIG_MISSING_BOARD_RESET to kukui so it won't build fail)
2. Add board-specific implementation to kukui.

Or, we should consider doing weak link for board_reset...

https://review.coreboot.org/#/c/31118/1/src/soc/mediatek/common/wdt_reset.c 
File src/soc/mediatek/common/wdt_reset.c:

https://review.coreboot.org/#/c/31118/1/src/soc/mediatek/common/wdt_reset.c@... 
PS1, Line 2: file
In other SOC, this is usually simply called reset.c. I think we should follow the convention even if the implementation is using watchdog.