Alec Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43478 )
Change subject: mb/google/dedede: Add P-sensor for Boten
......................................................................
Patch Set 9:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43478/8/src/mainboard/google/dedede...
File src/mainboard/google/dedede/variants/boten/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43478/8/src/mainboard/google/dedede...
PS8, Line 57: ""SAR Proximity Sensor""
Just to clarify, is this sensor added in Sub-board? […]
Yes, it is added in Sub-board.
I checked I2C5 have already enabled:
PAD_CFG_NF(GPP_D22, NONE, DEEP, NF1),
PAD_CFG_NF(GPP_D23, NONE, DEEP, NF1),
https://review.coreboot.org/c/coreboot/+/43478/8/src/mainboard/google/dedede...
PS8, Line 63: end
While adding P-Sensor, you removed the Audio amplifier codec configuration. Audio will be broken. […]
Done. I have recovered it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43478
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8e02c2cf477aa83b3d4c69ce84d48a8ad1a2560f
Gerrit-Change-Number: 43478
Gerrit-PatchSet: 9
Gerrit-Owner: Yan Liu
yan.liu@bitland.corp-partner.google.com
Gerrit-Reviewer: Alec Wang
alec.wang@lcfc.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Gwendal Grignou
gwendal@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 26 Sep 2020 02:43:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment