Attention is currently required from: Martin Roth, Julius Werner.
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50247 )
Change subject: Documentation: Codify some guidelines for headers and chain-including
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Patchset:
PS1:
Thanks! We probably have to collect the list of exceptions in a separate file and link it here.
here is what I've tried to list:
include/cbfs.h:
commonlib/cbfs.h:
commonlib/bsd/cbfs_private.h:
commonlib/bsd/cb_err.h
commonlib/bsd/cbfs_serialized.h
include/gpio.h:
soc/gpio.h
include/types.h:
commonlib/bsd/cb_err.h
stdbool.h
stdint.h
stddef.h
include/gpio.h:
soc/gpio.h
include/device/mmio.h:
arch/mmio.h
include/device/pci_ops.h:
arch/pci_ops.h:
device/pci_mmio_cfg.h
arch/pci_io_cfg.h:
arch/io.h
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50247
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibbcde306a814f52b3a41b58c7a33bdd99b0187e0
Gerrit-Change-Number: 50247
Gerrit-PatchSet: 1
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Wed, 03 Feb 2021 10:09:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment