Attention is currently required from: Arthur Heymans, Christian Walter, Johnny Lin, Lean Sheng Tan, Shuo Liu, Tim Chu.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81044?usp=email )
Change subject: soc/intel/xeon_sp: Add utils for VT-d BAR query ......................................................................
Patch Set 2:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81044/comment/1e8225d3_39f671c5 : PS2, Line 8: Missing motivation, problem statement or why it's beneficial to have.
File src/soc/intel/xeon_sp/uncore_acpi.c:
https://review.coreboot.org/c/coreboot/+/81044/comment/bbccaa83_870dff44 : PS2, Line 258: get_vtd_bar_from_stack Possible NULL pointer dereference.
https://review.coreboot.org/c/coreboot/+/81044/comment/f99afe18_c9e91f84 : PS2, Line 258: get_vtd_bar_from_stack There's no benefit calling get_vtd_bar_from_stack(). It just increases CPU load on boot since it need to iterate over the devicetree multiple times while the information is already present (ri->VtdBarAddress).
An improvement would be to iterate over all VTD devices and call acpi_create_drhd() for each instead of iterating over sockets and stacks.
https://review.coreboot.org/c/coreboot/+/81044/comment/4cddd797_180adc1e : PS2, Line 407: get_vtd_bar_from_dev probe_resource is the correct function to call since dev_find_device() already made sure that vendor and device ID matches.
https://review.coreboot.org/c/coreboot/+/81044/comment/e8028a83_29b0862a : PS2, Line 482: get_vtd_bar_from_dev probe_resource is the correct function to call since dev_find_device() already made sure that vendor and device ID matches.