Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/81285?usp=email )
Change subject: util/lint/lint: Fix shellcheck errors in getopt support for darwin ......................................................................
util/lint/lint: Fix shellcheck errors in getopt support for darwin
Posix shell doesn't support '=='
Change-Id: Icbdc4204f4c07d806e721fa39f96694c4df00e8d Signed-off-by: Martin Roth gaumless@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/81285 Reviewed-by: Patrick Georgi patrick@coreboot.org Reviewed-by: Paul Menzel paulepanter@mailbox.org Reviewed-by: Felix Singer service+coreboot-gerrit@felixsinger.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M util/lint/lint 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: Paul Menzel: Looks good to me, but someone else must approve Patrick Georgi: Looks good to me, approved Felix Singer: Looks good to me, approved build bot (Jenkins): Verified
diff --git a/util/lint/lint b/util/lint/lint index 1896db1..56edaa6 100755 --- a/util/lint/lint +++ b/util/lint/lint @@ -30,7 +30,7 @@ }
# Look if we have getopt. If not, build it. -if [ $(uname) == Darwin ]; then +if [ "$(uname)" = "Darwin" ]; then GETOPT="getopt hIJ" else GETOPT="getopt -l help,junit,invert -o hIJ"