[coreboot-gerrit] [M] Change in coreboot[master]: util/amdfwtool: Write EFS and AMDFW body in separate files

[Karthik Ramasubramanian (Code Review)]

Attention is currently required from: Bao Zheng, Raul Rangel, Martin L Roth, Felix Held.

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70778 )

Change subject: util/amdfwtool: Write EFS and AMDFW body in separate files
......................................................................

Patch Set 4:

(2 comments)

File util/amdfwtool/amdfwtool.c:

https://review.coreboot.org/c/coreboot/+/70778/comment/eac36654_927376d4 
PS2, Line 1967: efs_name
> You might want to write a .tmp file and rename it once it's created. […]

Done

File util/amdfwtool/amdfwtool.c:

https://review.coreboot.org/c/coreboot/+/70778/comment/69e300bd_75b2bcd1 
PS3, Line 1962: file_name_len = strlen(output) + strlen(EFS_FILE_SUFFIX) + strlen(TMP_FILE_SUFFIX) + 1;
              : 	if (file_name_len > PATH_MAX) {
              : 		fprintf(stderr, "EFS File name len %zu  > %u\n", file_name_len, PATH_MAX);
              : 		exit(1);
              : 	}
> You can check the return value of `snprintf` instead. […]

Done