[coreboot-gerrit] Change in coreboot[master]: amd/common/block/spi: Add EFS SPI configurations to Kconfig

[Matt Papageorge (Code Review)]

Matt Papageorge has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42567 )

Change subject: amd/common/block/spi: Add EFS SPI configurations to Kconfig
......................................................................

Patch Set 17:

(2 comments)

https://review.coreboot.org/c/coreboot/+/42567/17/src/soc/amd/common/block/s... 
File src/soc/amd/common/block/spi/Kconfig:

https://review.coreboot.org/c/coreboot/+/42567/17/src/soc/amd/common/block/s... 
PS17, Line 15: 	range 0 7
> em100 supports fast read. […]

See other reply. Feel free to open if you disagree.

https://review.coreboot.org/c/coreboot/+/42567/17/src/soc/amd/common/block/s... 
PS17, Line 33: 	range 0 5
> IIRC it generally needs to be at most 33MHz, but for zork devices the maximum frequency was lower du […]

I explicitly specified it in both Mandolin and Zork rather than relying on the default to remove any ambiguity. This will be useful when/if we refactor out the fast speed and mode from the device tree and use kconfig on a per-platform basis. Anyone browsing the code will be able to more easily determine the platform SPI speed without having to browse to the common kconfig.