Brandon Breitenstein has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39459 )
Change subject: soc/intel/tigerlake: Configure IOM_TYPEC_SW_CONFIGURATUON_3
......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39459/4/src/soc/intel/tigerlake/chi...
File src/soc/intel/tigerlake/chip.h:
https://review.coreboot.org/c/coreboot/+/39459/4/src/soc/intel/tigerlake/chi...
PS4, Line 236: 6
is this the right number for TGL?
IOM has the capability to control up to 6 Type-C ports so this is correct
https://review.coreboot.org/c/coreboot/+/39459/4/src/soc/intel/tigerlake/chi...
PS4, Line 237: 10
how does that work with a uint8_t?
I messed up this should be a uint16 fixing
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39459
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iae356113cbdc72983f800060b1ebebe3c66b9daf
Gerrit-Change-Number: 39459
Gerrit-PatchSet: 5
Gerrit-Owner: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 19 Mar 2020 22:15:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Caveh Jalali
caveh@chromium.org
Gerrit-MessageType: comment