Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47302 )
Change subject: soc/intel/xeon_sp: Synchronize DMAR and MADT IOAPIC id's ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47302/2/src/soc/intel/xeon_sp/skx/s... File src/soc/intel/xeon_sp/skx/soc_util.c:
https://review.coreboot.org/c/coreboot/+/47302/2/src/soc/intel/xeon_sp/skx/s... PS2, Line 306: }
I see that this matches the results of the ioapicid array, but what about the other skx Pstacks? Jonathan?
From the looks of it PSTACK3 and PSTACK4 also feature IIO's on SKX. Looping up to PSTACK2 is also done elsewhere in the ACPI code so that might need fixing too?