Edward O'Callaghan (eocallaghan@alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8077
-gerrit
commit 20908a48b3dae8f66af8b5415a20c13a1374d86d Author: Edward O'Callaghan eocallaghan@alterapraxis.com Date: Sun Jan 4 16:10:32 2015 +1100
superio/nsc/pc87366: Use link-time symbols over .c inclusion
Change-Id: Id156ca3c9a14c5bcc4d6cdb8434ca8efdac3139a Signed-off-by: Edward O'Callaghan eocallaghan@alterapraxis.com --- src/mainboard/ibm/e325/romstage.c | 2 +- src/mainboard/ibm/e326/romstage.c | 2 +- src/superio/nsc/pc87366/Makefile.inc | 1 + src/superio/nsc/pc87366/early_serial.c | 4 +++- src/superio/nsc/pc87366/pc87366.h | 11 ++++++++--- src/superio/nsc/pc87366/superio.c | 1 - 6 files changed, 14 insertions(+), 7 deletions(-)
diff --git a/src/mainboard/ibm/e325/romstage.c b/src/mainboard/ibm/e325/romstage.c index b44668a..4e1e925 100644 --- a/src/mainboard/ibm/e325/romstage.c +++ b/src/mainboard/ibm/e325/romstage.c @@ -13,7 +13,7 @@ #include "lib/delay.c" #include "northbridge/amd/amdk8/reset_test.c" #include "northbridge/amd/amdk8/debug.c" -#include "superio/nsc/pc87366/early_serial.c" +#include <superio/nsc/pc87366/pc87366.h> #include "cpu/x86/bist.h" #include "northbridge/amd/amdk8/setup_resource_map.c" #include <spd.h> diff --git a/src/mainboard/ibm/e326/romstage.c b/src/mainboard/ibm/e326/romstage.c index c703b7a..2ac90ab 100644 --- a/src/mainboard/ibm/e326/romstage.c +++ b/src/mainboard/ibm/e326/romstage.c @@ -13,7 +13,7 @@ #include "lib/delay.c" #include "northbridge/amd/amdk8/reset_test.c" #include "northbridge/amd/amdk8/debug.c" -#include "superio/nsc/pc87366/early_serial.c" +#include <superio/nsc/pc87366/pc87366.h> #include "cpu/x86/bist.h" #include "northbridge/amd/amdk8/setup_resource_map.c" #include "southbridge/amd/amd8111/early_ctrl.c" diff --git a/src/superio/nsc/pc87366/Makefile.inc b/src/superio/nsc/pc87366/Makefile.inc index 451f944..37ea1d8 100644 --- a/src/superio/nsc/pc87366/Makefile.inc +++ b/src/superio/nsc/pc87366/Makefile.inc @@ -19,4 +19,5 @@ ## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA ##
+romstage-$(CONFIG_SUPERIO_NSC_PC87366) += early_serial.c ramstage-$(CONFIG_SUPERIO_NSC_PC87366) += superio.c diff --git a/src/superio/nsc/pc87366/early_serial.c b/src/superio/nsc/pc87366/early_serial.c index e663df6..6cbef41 100644 --- a/src/superio/nsc/pc87366/early_serial.c +++ b/src/superio/nsc/pc87366/early_serial.c @@ -20,9 +20,11 @@ */
#include <arch/io.h> +#include <device/pnp.h> +#include <stdint.h> #include "pc87366.h"
-static void pc87366_enable_serial(pnp_devfn_t dev, u16 iobase) +void pc87366_enable_serial(pnp_devfn_t dev, u16 iobase) { pnp_set_logical_device(dev); pnp_set_enable(dev, 0); diff --git a/src/superio/nsc/pc87366/pc87366.h b/src/superio/nsc/pc87366/pc87366.h index 8a1ede7..dea8ddf 100644 --- a/src/superio/nsc/pc87366/pc87366.h +++ b/src/superio/nsc/pc87366/pc87366.h @@ -19,8 +19,8 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA */
-#ifndef SUPERIO_NSC_PC87366_PC87366_H -#define SUPERIO_NSC_PC87366_PC87366_H +#ifndef SUPERIO_NSC_PC87366_H +#define SUPERIO_NSC_PC87366_H
#define PC87366_FDC 0x00 /* Floppy */ #define PC87366_PP 0x01 /* Parallel port */ @@ -38,4 +38,9 @@ #define PC87366_VLM 0x0D #define PC87366_TMS 0x0E
-#endif +#include <arch/io.h> +#include <stdint.h> + +void pc87366_enable_serial(pnp_devfn_t dev, u16 iobase); + +#endif /* SUPERIO_NSC_PC87366_H */ diff --git a/src/superio/nsc/pc87366/superio.c b/src/superio/nsc/pc87366/superio.c index 9cfba04..9bf14fc 100644 --- a/src/superio/nsc/pc87366/superio.c +++ b/src/superio/nsc/pc87366/superio.c @@ -30,7 +30,6 @@
static void init(struct device *dev) { - if (!dev->enabled) return;