Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32107 )
Change subject: src/mb/Kconfig: Fix PCI subsystem IDs ......................................................................
Patch Set 3: Code-Review-1
(4 comments)
AFAICS, there are only four boards to review and they weren't. The convoluted commit message hides that very well.
The already removed code around these Kconfig symbols was triggered when the symbols were set and `1e.0 on` in the dt. So we can ignore everything but these:
$ git grep -l '1e.0\s*on' -- $(dirname $(git grep -l MAINBOARD_PCI_SUBSYS)) src/mainboard/aopen/dxplplusu/devicetree.cb src/mainboard/asrock/b75pro3-m/devicetree.cb src/mainboard/gigabyte/ga-h61m-s2pv/devicetree.cb src/mainboard/hp/compaq_8200_elite_sff/devicetree.cb
https://review.coreboot.org/#/c/32107/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32107/3//COMMIT_MSG@16 PS3, Line 16: one of the three reasons below: doesn't seem true
https://review.coreboot.org/#/c/32107/3/src/mainboard/aopen/dxplplusu/device... File src/mainboard/aopen/dxplplusu/devicetree.cb:
https://review.coreboot.org/#/c/32107/3/src/mainboard/aopen/dxplplusu/device... PS3, Line 27: #TODO: subsystemid ???? ???? inherit Why add this here? since when are subsystem ids a requirement?
https://review.coreboot.org/#/c/32107/3/src/mainboard/asrock/b75pro3-m/Kconf... File src/mainboard/asrock/b75pro3-m/Kconfig:
https://review.coreboot.org/#/c/32107/3/src/mainboard/asrock/b75pro3-m/Kconf... PS3, Line 42: Devicetree says 0x244e and uses 0x1e49 for the LPC bridge. However, I would guess that the dt is correct (it's easier to review and to understand during porting).
https://review.coreboot.org/#/c/32107/3/src/mainboard/gigabyte/ga-h61m-s2pv/... File src/mainboard/gigabyte/ga-h61m-s2pv/Kconfig:
https://review.coreboot.org/#/c/32107/3/src/mainboard/gigabyte/ga-h61m-s2pv/... PS3, Line 50: Devicetree doesn't set it, probably worth to fix?