Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39115 )
Change subject: mb/google/dedede: Add WLAN configuration
......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39115/5/src/mainboard/google/dedede...
File src/mainboard/google/dedede/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/39115/5/src/mainboard/google/dedede...
PS5, Line 154: PAD_CFG_GPI_SCI_LOW
Don't you need to configure the line to be routed to APIC in that case? Also, how does the kernel dr […]
After further investigation in hatch - eventhough the line is configured to be routed to APIC, there is no ACPI configuration to pass the GPIO info to kernel.
Also even in some of the variants of hatch, it is marked as Not Connected.
Aamir, Do you know how this line is used? If not, I will mark it as PAD_NC.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39115
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9bb8e57cdb688bc544929c94af380b9ef1d936a2
Gerrit-Change-Number: 39115
Gerrit-PatchSet: 9
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Wed, 11 Mar 2020 23:53:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment