Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Xixi Chen. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62065 )
Change subject: src/mediatek/mt8186: Get dram size from ddr_info rank_size array ......................................................................
Patch Set 1:
(7 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62065/comment/fc246ae9_0b4efaaf PS1, Line 8: BUG=b:206014043 TEST=...
File src/soc/mediatek/common/memory.c:
https://review.coreboot.org/c/coreboot/+/62065/comment/83736bc1_c5330930 PS1, Line 26: /* dram info which is passed to CBMEM */ This is irrelevant to this change. Please remove.
https://review.coreboot.org/c/coreboot/+/62065/comment/78f417c9_08307038 PS1, Line 27: One space.
https://review.coreboot.org/c/coreboot/+/62065/comment/15155ecf_af5e6a84 PS1, Line 269: (const struct ddr_base_info *) Will there be error if we don't explicitly cast it?
File src/soc/mediatek/mt8186/emi.c:
https://review.coreboot.org/c/coreboot/+/62065/comment/d554af25_df7264aa PS1, Line 10: extern const struct ddr_base_info *ddr_info; Please declare this in emi.h.
https://review.coreboot.org/c/coreboot/+/62065/comment/f588bcae_96e86e2e PS1, Line 10: ddr_info current_ddr_info?
https://review.coreboot.org/c/coreboot/+/62065/comment/35af5fd0_4dd9631f PS1, Line 16: RANK_MAX Should this be rank_num?