Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48608 )
Change subject: mb/google/kahlee: move SMI/SCI GPIO setup to ramstage ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48608/3/src/mainboard/google/kahlee... File src/mainboard/google/kahlee/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/48608/3/src/mainboard/google/kahlee... PS3, Line 19: PAD_GPI I know this change is already submitted. But, why configure the pads in early stage at all? Bootblock is meant to configure the bare minimum pads required to get upto ramstage. None of the EC_SMI_ODL/EC_SCI_ODL/EC_PCH_WAKE_L need to be configured in early stages. We should just drop their configuration in bootblock and rely on ramstage to do the right thing.