19 Apr
2021
19 Apr
'21
3:50 p.m.
Attention is currently required from: Arthur Heymans. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36712 )
Change subject: sb/intel/lynxpoint: Setup gpio in bootblock ......................................................................
Patch Set 5:
(1 comment)
File src/southbridge/intel/lynxpoint/bootblock.c:
https://review.coreboot.org/c/coreboot/+/36712/comment/b6d2efab_f246f1e5 PS5, Line 91: #endif I'd do this in bootblock_early_southbridge_init() because SerialIO UART depends on GPIOs being programmed properly.
--
To view, visit https://review.coreboot.org/c/coreboot/+/36712
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I448ca12f5ddab362983429c508e518b7042ef760
Gerrit-Change-Number: 36712
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Tristan Corrick tristan@corrick.kiwi
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Comment-Date: Mon, 19 Apr 2021 13:50:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment