[coreboot-gerrit] Change in ...coreboot[master]: security/tpm/tss/tcg-2.0: Add TPM2 function tlcl_getcapability()

[Frans Hendriks (Code Review)]

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30826 )

Change subject: security/tpm/tss/tcg-2.0: Add TPM2 function tlcl_getcapability()
......................................................................

Patch Set 16:

(2 comments)

https://review.coreboot.org/#/c/30826/15/src/security/tpm/tss/tcg-2.0/tss.c 
File src/security/tpm/tss/tcg-2.0/tss.c:

https://review.coreboot.org/#/c/30826/15/src/security/tpm/tss/tcg-2.0/tss.c@... 
PS15, Line 373:  * Please note that the capabilityData is not unmarshalled.
> Which input parameter? Isn't capabilityData purely an output parameter? (BTW the naming convention i […]

My mistake during reviewing the code. 
To avoid confision I have removed this comment. The response data will be just copied.

https://review.coreboot.org/#/c/30826/15/src/security/tpm/tss/tcg-2.0/tss.c@... 
PS15, Line 403: 		sizeof(TPMI_YES_NO) - sizeof(struct tpm_header));
> You're passing in a TPMS_CAPABILITY_DATA struct here, that has a well-known size. […]

The response data will be just copied.