Attention is currently required from: Martin L Roth, Elyes Haouas.
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70199 )
Change subject: util/xcompile: Remove the extra "/" added after {XGCCPATH} ......................................................................
Patch Set 1:
(2 comments)
File util/xcompile/xcompile:
https://review.coreboot.org/c/coreboot/+/70199/comment/14dc9caf_28ca1967 PS1, Line 16: XGCCPATH=$1 What if someone has crossgcc compiled under different path (like ChromeOS SDK does it)? This change can potentially break many build scripts out there, so I'd be careful.
https://review.coreboot.org/c/coreboot/+/70199/comment/460c49e6_6044f847 PS1, Line 21: XGCCPATH=${XGCCPATH:-"$(pwd)/../../../../util/crossgcc/xgcc/bin/"} I think it would be better to just remove slashes from these paths instead and leave them in other places for clarity and readability. (Even `dirname $DIR`) returns path without trailing slash)