Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30958 )
Change subject: superio/wpcm450: fix keyboard IO masks
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/#/c/30958/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/30958/1//COMMIT_MSG@8
PS1, Line 8:
Also add:
The IO mask shouldn't contain zeros inside the block of ones.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30958
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7319ce9f84181759f4dc7b59c0020f3a5dd5dc03
Gerrit-Change-Number: 30958
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 16 Jan 2019 13:09:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment