[coreboot-gerrit] Change in coreboot[master]: soc/intel/tigerlake: Add Acoustic features

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45052 )

Change subject: soc/intel/tigerlake: Add Acoustic features
......................................................................

Patch Set 9:

(4 comments)

https://review.coreboot.org/c/coreboot/+/45052/9/src/soc/intel/tigerlake/fsp... 
File src/soc/intel/tigerlake/fsp_params.c:

https://review.coreboot.org/c/coreboot/+/45052/9/src/soc/intel/tigerlake/fsp... 
PS9, Line 261: *
nit: spaces around operators please

https://review.coreboot.org/c/coreboot/+/45052/9/src/soc/intel/tigerlake/fsp... 
PS9, Line 261: sizeof(uint8_t)
May be better to be more explicit here: sizeof(config->SlowSlewRate[0])

https://review.coreboot.org/c/coreboot/+/45052/9/src/soc/intel/tigerlake/fsp... 
PS9, Line 264: *
nit: spaces around operators please

https://review.coreboot.org/c/coreboot/+/45052/9/src/soc/intel/tigerlake/fsp... 
PS9, Line 264: sizeof(uint8_t)
May be better to be more explicit here: sizeof(config->FastPkgCRampDisable[0])