Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48448 )
Change subject: mb/google/dedede/var/magolor: Add Wifi SAR for magolor and maglia ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/48448/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48448/1//COMMIT_MSG@13 PS1, Line 13: BUG=b:173001370 b:173001251 Nit: b:173001370, b:173001251
https://review.coreboot.org/c/coreboot/+/48448/1//COMMIT_MSG@16 PS1, Line 16: Cq-Depend: chrome-internal:3453724
https://review.coreboot.org/c/coreboot/+/48448/1/src/mainboard/google/dedede... File src/mainboard/google/dedede/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/48448/1/src/mainboard/google/dedede... PS1, Line 70: select GEO_SAR_ENABLE if CHROMEOS_WIFI_SAR Nit: Move above "select SOC_INTEL_COMMON_BLOCK_IPU"