Piotr Kleinschmidt has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42512 )
Change subject: mb/pcengines/apu1/mainboard.c: fix apu1 serial number counting
......................................................................
Patch Set 1:
Patch Set 1:
While this woraround might work, it seems to be solving the wrong problem and being possibly unreliable to me. Might this be related to the resource allocator changes?
To be honest, I don't know what is the source of original problem, so this workaround is done only to fix serial number issue. I will just add that every NIC shows this problem - secondary bus number is shifted 8 bits left. That's why I suggested that it might be related to enumeration phase already. What exactly do you mean by resource allocator changes?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42512
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5e8690d100b38ac7889395d375c0ff32bdefda0b
Gerrit-Change-Number: 42512
Gerrit-PatchSet: 1
Gerrit-Owner: Piotr Kleinschmidt
piotr.kleinschmidt@3mdeb.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 29 Jun 2020 08:50:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment