Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40338 )
Change subject: cpu/x86/acpi: Add assignments to ACPI_Sn enums
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40338/1/src/arch/x86/include/arch/a...
File src/arch/x86/include/arch/acpi.h:
https://review.coreboot.org/c/coreboot/+/40338/1/src/arch/x86/include/arch/a...
PS1, Line 956: ACPI_S0
I made the same comment in a chromium CL. And add a comment that we want those explicit values.
Done
https://review.coreboot.org/c/coreboot/+/40338/1/src/arch/x86/include/arch/a...
PS1, Line 980: acpi_snum_from_pm1
This function is the exact same as acpi_sleep_from_pm1. […]
removed in later versions
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40338
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1de2e7f65a2dc3f8a9a1c5fd83d164871a4a2b96
Gerrit-Change-Number: 40338
Gerrit-PatchSet: 4
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 14 Apr 2020 19:39:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment