Attention is currently required from: Hung-Te Lin, Paul Menzel, Yidi Lin, Yu-Ping Wu.
Xin Ji has posted comments on this change by Xin Ji. ( https://review.coreboot.org/c/coreboot/+/86101?usp=email )
Change subject: mb/google/corsola: Increase ANX7625 data trail time ......................................................................
Patch Set 1:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/86101/comment/73d61087_bc6a2090?usp... : PS1, Line 7: fine tune the data lane trail
More specific: […]
OK
https://review.coreboot.org/c/coreboot/+/86101/comment/21d69099_6b7f9521?usp... : PS1, Line 8:
Please start by describing the problem, like: Currently, the display flickers.
OK
https://review.coreboot.org/c/coreboot/+/86101/comment/31622428_9f3fee29?usp... : PS1, Line 9: ANX7625 requires customized hs_da_trail time
Why? According to the schematics?
I'll add more description.
https://review.coreboot.org/c/coreboot/+/86101/comment/70376854_5f9c0a86?usp... : PS1, Line 9: override the : data trail for ANX7625
What is the current value, and what is the new value? Why is the new value correct?
I'm not sure current value, need ask MTK.
File src/mainboard/google/corsola/panel_anx7625.c:
https://review.coreboot.org/c/coreboot/+/86101/comment/27a4cc49_a1c289a1?usp... : PS1, Line 69: timing->da_hs_trail += 9;
Maybe better use the absolute value, or does it always need to be increased by nine?
I cannot use the absolute value, I'm not sure the original value.