Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48565 )
Change subject: soc/amd/cezanne: add GPIO support
......................................................................
Patch Set 7: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/48565/7/src/soc/amd/cezanne/gpio.c
File src/soc/amd/cezanne/gpio.c:
https://review.coreboot.org/c/coreboot/+/48565/7/src/soc/amd/cezanne/gpio.c@...
PS7, Line 10: gpio_event_table
from the IOMUX function table in the PPR; one column in it is the GPIO number and one has the GEVENT […]
Ah, that makes it easier to review :) You can add a comment if you want.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48565
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6c12d1d6c605b7eb063eef62a1f71860f602f8dd
Gerrit-Change-Number: 48565
Gerrit-PatchSet: 7
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 16 Dec 2020 20:17:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment