26 Jan
2019
26 Jan
'19
2:50 p.m.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31108 )
Change subject: sb/intel/common/firmware: Don't call GbE binary `firmware` ......................................................................
Patch Set 1: Code-Review-1
(1 comment)
https://review.coreboot.org/#/c/31108/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31108/1//COMMIT_MSG@8 PS1, Line 8: i don't know from where you get this details about calling it gbe configuration. if you really keen not calling it "firmware" then use gbe "binary file".
I don't think its correct word to use configuration. do you have background what kind of configuration this binary has ?
--
To view, visit https://review.coreboot.org/c/coreboot/+/31108
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ife6190639e7f05da2cb6eddeb1b0db0e8ffc8e6e
Gerrit-Change-Number: 31108
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: Tristan Corrick tristan@corrick.kiwi
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 26 Jan 2019 13:50:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment