14 Jul
2021
14 Jul
'21
4:07 p.m.
Attention is currently required from: Maxim Polyakov. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47595 )
Change subject: ec/kontron/kempld: Add minimal GPIO driver ......................................................................
Patch Set 14: Code-Review+2
(1 comment)
File src/ec/kontron/kempld/kempld_internal.h:
https://review.coreboot.org/c/coreboot/+/47595/comment/41a157fb_656f5bee PS12, Line 31: #define KEMPLD_GPIO_MASK(x) (1 << ((x) % 8)) : #define KEMPLD_GPIO_DIR(pad_num) (0x40 + (pad_num) / 8) : #define KEMPLD_GPIO_LVL(pad_num) (0x42 + (pad_num) / 8)
Missed KEMPLD_GPIO_MASK
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/47595
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id767aa451fbf2ca1c0dccfc9aa2c024c6f37c1bb
Gerrit-Change-Number: 47595
Gerrit-PatchSet: 14
Gerrit-Owner: Maxim Polyakov max.senia.poliak@gmail.com
Gerrit-Reviewer: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Werner Zeh werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Maxim Polyakov max.senia.poliak@gmail.com
Gerrit-Comment-Date: Wed, 14 Jul 2021 16:07:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Maxim Polyakov max.senia.poliak@gmail.com
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment