Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37794 )
Change subject: soc/intel/cannonlake: Pass MISCCFG.bit 0-5 devicetree.cb to ASL ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37794/1/src/soc/intel/cannonlake/gp... File src/soc/intel/cannonlake/gpio_common.c:
https://review.coreboot.org/c/coreboot/+/37794/1/src/soc/intel/cannonlake/gp... PS1, Line 27: else
Do we need this? FPS-S will enable it anyway right?
valid point, i guess my proposal would be don't bother about what FSP sets, we are independent in this way.
If we can pass gpio_override_pm this to GNVS, I can use the flag to do overwrite or do nothing.
yes, gpio_override_pm is going into GNVS, look for OGPM, based on this you can decided to override those values else leave it to its default value as this else will anyway taken care. https://review.coreboot.org/c/coreboot/+/37793/1/src/soc/intel/common/block/...