build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18457 )
Change subject: [WIP]soc/intel/common: Add bootblock common stage file ......................................................................
Patch Set 15:
(10 comments)
https://review.coreboot.org/#/c/18457/15/src/soc/intel/common/basecode/bootb... File src/soc/intel/common/basecode/bootblock/bootblock.c:
https://review.coreboot.org/#/c/18457/15/src/soc/intel/common/basecode/bootb... PS15, Line 59: * Enabling PWRM Base for accessing code indent should use tabs where possible
https://review.coreboot.org/#/c/18457/15/src/soc/intel/common/basecode/bootb... PS15, Line 60: * Global Reset Cause Register. code indent should use tabs where possible
https://review.coreboot.org/#/c/18457/15/src/soc/intel/common/basecode/bootb... PS15, Line 61: */ code indent should use tabs where possible
https://review.coreboot.org/#/c/18457/15/src/soc/intel/common/basecode/bootb... PS15, Line 188: bb_ops->bootblock_soc_early_init= &bootblock_cmn_soc_early_init, spaces required around that '=' (ctx:VxW)
https://review.coreboot.org/#/c/18457/15/src/soc/intel/common/basecode/bootb... PS15, Line 190: bb_ops->bootblock_pch_early_init= &bootblock_cmn_pch_early_init, spaces required around that '=' (ctx:VxW)
https://review.coreboot.org/#/c/18457/15/src/soc/intel/common/basecode/bootb... PS15, Line 192: bb_ops->bootblock_cpu_early_init= &bootblock_cmn_cpu_early_init, spaces required around that '=' (ctx:VxW)
https://review.coreboot.org/#/c/18457/15/src/soc/intel/common/basecode/bootb... PS15, Line 193: bb_ops->bootblock_cpu_init = &bootblock_cmn_cpu_init; please, no space before tabs
https://review.coreboot.org/#/c/18457/15/src/soc/intel/common/basecode/bootb... PS15, Line 196: __weak void soc_update_ops(struct bootblock_ops* ops) "foo* bar" should be "foo *bar"
https://review.coreboot.org/#/c/18457/15/src/soc/intel/common/basecode/bootb... PS15, Line 201: void asmlinkage bootblock_c_entry(uint64_t base_timestamp) storage class 'asmlinkage' should be located before type 'void'
https://review.coreboot.org/#/c/18457/15/src/soc/intel/common/basecode/inclu... File src/soc/intel/common/basecode/include/intelbasecode/bootblock.h:
https://review.coreboot.org/#/c/18457/15/src/soc/intel/common/basecode/inclu... PS15, Line 36: void soc_update_ops(struct bootblock_ops* soc_ops); "foo* bar" should be "foo *bar"