Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42434 )
Change subject: x86/lapic: Set EXTINT on BSP only
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42434/4/src/cpu/x86/lapic/lapic.c
File src/cpu/x86/lapic/lapic.c:
https://review.coreboot.org/c/coreboot/+/42434/4/src/cpu/x86/lapic/lapic.c@9
PS4, Line 9: uint32_t
unsigned long
actually, the lapic functions are wrong
https://review.coreboot.org/c/coreboot/+/42434/4/src/cpu/x86/lapic/lapic.c@1...
PS4, Line 13: uint32_t
unsigned long
actually, the lapic functions are wrong
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42434
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I78490d2cbe3d9f52e10ef2471508263fd6c146ba
Gerrit-Change-Number: 42434
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Zheng Bao
zheng.bao@amd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 18 Jun 2020 11:56:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment