Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37996 )
Change subject: soc/mediatek/mt8183: Do TX tracking for DRAM DVFS feature ......................................................................
Patch Set 14:
(3 comments)
https://review.coreboot.org/c/coreboot/+/37996/9/src/soc/mediatek/mt8183/dra... File src/soc/mediatek/mt8183/dramc_pi_calibration_api.c:
https://review.coreboot.org/c/coreboot/+/37996/9/src/soc/mediatek/mt8183/dra... PS9, Line 2150: u8 mr23 = 0x3F;
I think no need add a comment for this.
Ack
https://review.coreboot.org/c/coreboot/+/37996/9/src/soc/mediatek/mt8183/dra... PS9, Line 2314: static int div_round_close(const int n, const int d)
replace with common API DIV_ROUND_CLOSEST later
Done
https://review.coreboot.org/c/coreboot/+/37996/9/src/soc/mediatek/mt8183/emi... File src/soc/mediatek/mt8183/emi.c:
https://review.coreboot.org/c/coreboot/+/37996/9/src/soc/mediatek/mt8183/emi... PS9, Line 87: freq_tbl = freq_shuffle;
freq_tbl = CONFIG_MT8183_DRAM_EMCP ? freq_shuffle_emcp : freq_shuffle
Done