Attention is currently required from: Kane Chen, Kapil Porwal, Kun Liu, Reka Norman, Stefan Reinauer.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79902?usp=email )
Change subject: util/ifdtool: Enable Read Access for SPI device expansion 2 region
......................................................................
Patch Set 1:
(1 comment)
File util/ifdtool/ifdtool.c:
https://review.coreboot.org/c/coreboot/+/79902/comment/aac15bad_17fb7df1 :
PS1, Line 65: "Device Exp2
Does the name need to be updated or do they mean the same thing? (I'm not really sure what either device expansion or SPI padding regions are used for.)
I believe this name field is kind of volatile meaning it's like a reserved range for Intel and keeps on getting change over generation. Let me make some modification to keep "Device Exp2" uniformly w/o adding "SPI padding region"
I have lost ur CR+2 in this process. requesting you to please take a relook.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79902?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I18c44aa9a0f890f01a889247da118b69a58936e8
Gerrit-Change-Number: 79902
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Kun Liu
liukun11@huaqin.corp-partner.google.com
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Kane Chen
kane.chen@intel.com
Gerrit-Attention: Kun Liu
liukun11@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Fri, 12 Jan 2024 04:07:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Reka Norman
rekanorman@chromium.org
Gerrit-MessageType: comment