Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34664 )
Change subject: lib/stage_cache: Refactor Kconfig options
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34664/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34664/2//COMMIT_MSG@12
PS2, Line 12: Platforms with SMM_TSEG=y always need to implement
: stage_cache_external_region(). It is allowed to return with a
: region of size 0 to effectively disable the cache.
I believe amd/stoneyridge has a hard requirement to have stage_cache for S3 since it uses stage_cach […]
There is followup work that promotes smm_subregion() such that both PARALLEL_MP and TSEG_STAGE_CACHE can build on top of that. Not all work has been pushed for review yet.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34664
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibbdc701ea85b5a3208ca4e98c428b05b6d4e5340
Gerrit-Change-Number: 34664
Gerrit-PatchSet: 3
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 06 Aug 2019 05:26:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment