Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31271 )
Change subject: binaryPI: Drop nested northbridge in devicetree
......................................................................
Patch Set 1:
Patch Set 1:
This nesting was already removed for soc/stoney and AGESA boards.
Kyosti, you have an apu2 board, or some other way to test this, right? Marc had originally changed that whole chip/domain/northbridge nesting on stoneyridge to match the Intel systems more closely. I don't recall if he ran into any dependencies in the process.
I have already tested the patch on apu2.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31271
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic12481b637ee5f5119faec3239b477f613e4e511
Gerrit-Change-Number: 31271
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 12 Feb 2019 11:02:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment