Attention is currently required from: Michał Żygowski, Benjamin Doron, Paul Menzel, Michał Kopeć, Christian Walter, Julius Werner, Angel Pons, Maximilian Brune, Arthur Heymans, Krystian Hebel.
Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68749 )
Change subject: util/cbmem: add parsing of TPM logs per standard
......................................................................
Patch Set 16:
(1 comment)
File src/lib/coreboot_table.c:
https://review.coreboot.org/c/coreboot/+/68749/comment/c2bf11a2_a4c7adf2
PS15, Line 298: tatic void lb_tpm_std_log(struct lb_header *header)
: {
: struct lb_range *lb_range;
: const struct cbmem_entry *entry;
:
: entry = cbmem_entry_find(CBMEM_ID_TCPA_TCG_LOG);
: if (entry == NULL)
: entry = cbmem_entry_find(CBMEM_ID_TPM2_TCG_LOG);
: if (entry == NULL)
: return; /* The section is not present */
:
: lb_range = (struct lb_range *)lb_new_record(header);
: if (lb_range == NULL) {
: printk(BIOS_ERR, "No more room in coreboot table!\n");
: return;
: }
: lb_range->tag = LB_TAG_TPM_STD_LOG;
: lb_range->size = sizeof(*lb_range);
: lb_range->range_start = (uintptr_t)cbmem_entry_start(entry);
: lb_range->range_size = cbmem_entry_size(entry);
: }
There's actually also lb_cbmem_entry (see cbmem_add_records_to_cbtable() in lib/imd_cbmem. […]
Thanks, used that instead.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68749
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib76dc7dec56dd1789a219539a1ac05a958f47a5c
Gerrit-Change-Number: 68749
Gerrit-PatchSet: 16
Gerrit-Owner: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-CC: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Comment-Date: Wed, 10 May 2023 18:30:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-MessageType: comment