Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38421 )
Change subject: commonlib/bsd: Add new CBFS core implementation ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38421/7/src/commonlib/bsd/include/c... File src/commonlib/bsd/include/commonlib/bsd/cb_err.h:
https://review.coreboot.org/c/coreboot/+/38421/7/src/commonlib/bsd/include/c... PS7, Line 41: CB_CBFS_HASH
I would add some word to this to make its meaning a bit clearer, how about `CB_CBFS_HASH_CHECK_FAIL` […]
I prefer to avoid words like "fail" or "error" in error codes because the fact that it's an error code already makes that clear. This is similar in philosophy to POSIX errno (e.g. it's EACCES and EIO, not EACCESSDENIED and EIOERROR). But I could settle for CB_CBFS_HASH_MISMATCH if you like.