Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38904 )
Change subject: BUG#254 : Fixed configuration for DDR Size discovered by coreboot ......................................................................
Patch Set 5: Code-Review+1
(8 comments)
Welcome to coreboot! Thank you for reporting and fixing the issue.
https://review.coreboot.org/c/coreboot/+/38904/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38904/5//COMMIT_MSG@7 PS5, Line 7: BUG#254 : Fixed configuration for DDR Size discovered by coreboot Thank you. Please use something like below as commit message summary.
qemu-riscv: Fix discovered DDR size
https://review.coreboot.org/c/coreboot/+/38904/5//COMMIT_MSG@9 PS5, Line 9: For qemu-riscv value was incorrect. It was set to 32768 which : in turn was being used as 32768MB (32+GB), instead of the 32MB : it was intended to represent. You could use present tense.
https://review.coreboot.org/c/coreboot/+/38904/5//COMMIT_MSG@16 PS5, Line 16: are : Please remove the space before the colon.
https://review.coreboot.org/c/coreboot/+/38904/5//COMMIT_MSG@28 PS5, Line 28: Please add:
Also:
TEST=…
with the command you tested this with.
https://review.coreboot.org/c/coreboot/+/38904/5/src/mainboard/emulation/qem... File src/mainboard/emulation/qemu-riscv/Kconfig:
https://review.coreboot.org/c/coreboot/+/38904/5/src/mainboard/emulation/qem... PS5, Line 62: on the qemu cmdline. Please move this on the line above.
https://review.coreboot.org/c/coreboot/+/38904/5/src/mainboard/emulation/qem... PS5, Line 67: Choose this option if you want coreboot to find 256MB DDR Please add a dot/period at the end.
https://review.coreboot.org/c/coreboot/+/38904/5/src/mainboard/emulation/qem... File src/mainboard/emulation/qemu-riscv/mainboard.c:
https://review.coreboot.org/c/coreboot/+/38904/5/src/mainboard/emulation/qem... PS5, Line 30: 1024 KiB
https://review.coreboot.org/c/coreboot/+/38904/5/src/soc/ucb/riscv/cbmem.c File src/soc/ucb/riscv/cbmem.c:
https://review.coreboot.org/c/coreboot/+/38904/5/src/soc/ucb/riscv/cbmem.c@2... PS5, Line 20: 1024 KiB