Welcome to coreboot! Thank you for reporting and fixing the issue.
Patch set 5:Code-Review +1
8 comments:
Patch Set #5, Line 7: BUG#254 : Fixed configuration for DDR Size discovered by coreboot
Thank you. Please use something like below as commit message summary.
qemu-riscv: Fix discovered DDR size
For qemu-riscv value was incorrect. It was set to 32768 which
in turn was being used as 32768MB (32+GB), instead of the 32MB
it was intended to represent.
You could use present tense.
Patch Set #5, Line 16: are :
Please remove the space before the colon.
Please add:
Fixes: https://ticket.coreboot.org/issues/254
Also:
TEST=…
with the command you tested this with.
File src/mainboard/emulation/qemu-riscv/Kconfig:
Patch Set #5, Line 62: on the qemu cmdline.
Please move this on the line above.
Patch Set #5, Line 67: Choose this option if you want coreboot to find 256MB DDR
Please add a dot/period at the end.
File src/mainboard/emulation/qemu-riscv/mainboard.c:
KiB
File src/soc/ucb/riscv/cbmem.c:
KiB
To view, visit change 38904. To unsubscribe, or for help writing mail filters, visit settings.