Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39980 )
Change subject: soc/intel/skylake: vr_config: enable PSI3 and PSI4 by default ......................................................................
Patch Set 7:
Patch Set 7:
Patch Set 7:
Patch Set 7: Code-Review+2
Patch Set 7:
Patch Set 6:
whoops, looks like I pushed an older patch when I rebased another change, I'll fix that
Ah, alright. Not a problem (maybe -1 was unnecessary)
A -1 is not a blocker. In fact, it's a good way to indicate mild dissatisfaction with a change, as it stands out in a field of green scores.
but -1 is not a thing that should be used just because of a wrong comment IMHO
There are no real guidelines, what -1 means. So do not interpret too much into it, besides another iteration is needed. -1 scores will get removed with the next iteration, so in my opinion it’s a good way to prevent accidental submission of the change-set. Though, as comments need to be explicitly marked as resolved nowadays, -1 are not needed for that anymore.
Though, as comments need to be explicitly marked as resolved nowadays,
Yeah, that's what I actually meant but didn't say :)