Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34838 )
Change subject: mb/up/squared: Do RAM config based on SKU ID ......................................................................
Patch Set 5: Code-Review-1
(3 comments)
Please test this code on hardware.
https://review.coreboot.org/c/coreboot/+/34838/5/src/mainboard/up/squared/ro... File src/mainboard/up/squared/romstage.c:
https://review.coreboot.org/c/coreboot/+/34838/5/src/mainboard/up/squared/ro... PS5, Line 31: const uint8_t memory_skuid_pads[] = { GPIO_27, GPIO_28 }; static
https://review.coreboot.org/c/coreboot/+/34838/5/src/mainboard/up/squared/ro... PS5, Line 159: uint8_t rx_state = gpio_value & 0x2; rx_state is always 0
https://review.coreboot.org/c/coreboot/+/34838/5/src/mainboard/up/squared/ro... PS5, Line 162: memory_skuid = memory_skuid & 0x3; pointless operation