Please test this code on hardware.

Patch set 5:Code-Review -1

View Change

3 comments:

• File src/mainboard/up/squared/romstage.c:

  • Patch Set #5, Line 31: const uint8_t memory_skuid_pads[] = { GPIO_27, GPIO_28 };

    static

  • Patch Set #5, Line 159: uint8_t rx_state = gpio_value & 0x2;

    rx_state is always 0

  • Patch Set #5, Line 162: memory_skuid = memory_skuid & 0x3;

    pointless operation

To view, visit change 34838. To unsubscribe, or for help writing mail filters, visit settings.