Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34783 )
Change subject: vc/amd/cimx/sb800: Remove old strict-aliasing workaround
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/34783/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34783/1//COMMIT_MSG@35
PS1, Line 35: ReadMEM() and WriteMEM() now match their definitions in the SB900 code.
AGESA platforms build with -fno-strict-aliasing. […]
AGESA is built with GCC not trying to apply strict aliasing rules, SB900 never claimed to have an issue to begin with, so I guess this is good to go in.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34783
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia7e3a1eff88b855a05b33c7dafba16ed23784e43
Gerrit-Change-Number: 34783
Gerrit-PatchSet: 1
Gerrit-Owner: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 20 Aug 2019 15:38:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Jacob Garber
jgarber1@ualberta.ca
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment