build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27585 )
Change subject: cpu/intel/smm/gen1: Use correct MSR for model_6fx and model_1067x ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/#/c/27585/2/src/cpu/intel/smm/gen1/smmrelocate.c File src/cpu/intel/smm/gen1/smmrelocate.c:
https://review.coreboot.org/#/c/27585/2/src/cpu/intel/smm/gen1/smmrelocate.c... PS2, Line 78: && (msr.lo & FEATURE_CONTROL_LOCK_BIT))) { code indent should use tabs where possible
https://review.coreboot.org/#/c/27585/2/src/cpu/intel/smm/gen1/smmrelocate.c... PS2, Line 78: && (msr.lo & FEATURE_CONTROL_LOCK_BIT))) { please, no space before tabs
https://review.coreboot.org/#/c/27585/2/src/cpu/intel/smm/gen1/smmrelocate.c... PS2, Line 164: /* for model_6fx and model_1067x byte [0:11] on smrr_base are reserved */ line over 80 characters
https://review.coreboot.org/#/c/27585/2/src/cpu/intel/smm/gen1/smmrelocate.c... PS2, Line 169: params->smrr_base.lo = (params->smram_base & rmask) | MTRR_TYPE_WRBACK; line over 80 characters