Sindhoor Tilak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43000 )
Change subject: post_code: add missing postcode calls ......................................................................
Patch Set 6:
(3 comments)
https://review.coreboot.org/c/coreboot/+/43000/6/src/drivers/amd/agesa/romst... File src/drivers/amd/agesa/romstage.c:
https://review.coreboot.org/c/coreboot/+/43000/6/src/drivers/amd/agesa/romst... PS6, Line 87: post_code
Move into run_postcar_phase
Ack
https://review.coreboot.org/c/coreboot/+/43000/6/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/raminit_mrc.c:
https://review.coreboot.org/c/coreboot/+/43000/6/src/northbridge/intel/sandy... PS6, Line 366: POST_ROM_SDRAM_INIT
Where's the difference to POST_RAM_INIT ?
RAM_INIT is before the beginning of raminit, while this is for beginning of UEFI PEI raminit
https://review.coreboot.org/c/coreboot/+/43000/6/src/soc/intel/broadwell/rom... File src/soc/intel/broadwell/romstage/romstage.c:
https://review.coreboot.org/c/coreboot/+/43000/6/src/soc/intel/broadwell/rom... PS6, Line 79: post_code
Move into romstage_handoff_init
Ack