Prashant Malani has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40024 )
Change subject: google/chromeec: Add USB MUX Interrupt
......................................................................
Patch Set 2:
Patch Set 1:
Patch Set 1: Code-Review-1
Adding pmalani@.
Prashant told me last week that this change is no longer necessary for extcon events.
That is for the cros_ec change (EXT device) this change is still needed
Would you happen to know what kernel driver is servicing this interrupt?
Also, when exactly in the PD discovery and mode entry process is this interrupt triggered?
We want to back out the HACK which causes the LPC driver to call the notifier chain on every interrupt.
I have 2 CLs (https://chromium-review.googlesource.com/q/hashtag:%22extcon-pd-notify%22+(s...)) that use the PD notifier mechanism, which is what will be used once extcon is removed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40024
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie3a2f829a295f090a03e72e12f19ecc5bb724952
Gerrit-Change-Number: 40024
Gerrit-PatchSet: 2
Gerrit-Owner: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Prashant Malani
pmalani@chromium.org
Gerrit-Reviewer: Utkarsh H Patel
utkarsh.h.patel@intel.com
Gerrit-Reviewer: Vijay P Hiremath
vijay.p.hiremath@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Prashant Malani
pmalani@google.com
Gerrit-Comment-Date: Wed, 01 Apr 2020 21:18:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment