Attention is currently required from: Jérémy Compostella, Marshall Dawson.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78072?usp=email )
Change subject: */include/cpu: use unsigned int for number of address bits
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
I know it won't change a lot but shouldn't be using size_t to handle a size ?
hmm, good question. since i expect that values to be at most 64, i don't think that this would make any difference in practice
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78072?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9e67db6bf0c38f743b50e7273449cc028de13a8c
Gerrit-Change-Number: 78072
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Comment-Date: Thu, 28 Sep 2023 21:32:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-MessageType: comment