Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32665 )
Change subject: mb/google/hatch: Fine tune Goodix touch screen timing
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/32665/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/32665/1//COMMIT_MSG@14
PS1, Line 14: coldboot(10 times), warmboot(10 times), S3(10 times).
Please add a space before (.
https://review.coreboot.org/#/c/32665/1//COMMIT_MSG@16
PS1, Line 16: Signed-off-by: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com
Please move that below the Change-Id line.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32665
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4bf081bab5e89d3ce336c6432da5ba71279fa98d
Gerrit-Change-Number: 32665
Gerrit-PatchSet: 1
Gerrit-Owner: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Reviewer: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alan Lee
alan_lee@compal.corp-partner.google.com
Gerrit-CC: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-CC: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-CC: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Comment-Date: Tue, 07 May 2019 10:10:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment