John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43412 )
Change subject: mb/intel/tglrvp: Add PMC.MUX.CONx devices to devicetree for tglrvp_up4
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43412/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/43412/1//COMMIT_MSG@13
PS1, Line 13: TEST=Built image-tglrvp-up4.bin successfully.
have you cross referenced the USB port numbers with the schematics for your -Y board? the orientatio […]
USB port numbers had been crossed reference from the TGLRVP Y schematic. USB2 and USB3 port numbers are referred from Y boards's EC USB-C ports configuration. There are retimers for all ports.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43412
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8423ddbb5bc189899a9e19e7da6e2ee7b7fecc18
Gerrit-Change-Number: 43412
Gerrit-PatchSet: 1
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Divya S Sasidharan
divya.s.sasidharan@intel.com
Gerrit-Reviewer: Shamile Khan
shamile.khan@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 21 Jul 2020 23:22:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Wonkyu Kim
wonkyu.kim@intel.com
Comment-In-Reply-To: Caveh Jalali
caveh@chromium.org
Comment-In-Reply-To: John Zhao
john.zhao@intel.com
Gerrit-MessageType: comment