Attention is currently required from: Paul Menzel, Keith Hui. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41098 )
Change subject: mb/asus/p2b: Add ACPI support for p3b-f ......................................................................
Patch Set 11:
(10 comments)
File src/mainboard/asus/p2b/suspend.asl:
https://review.coreboot.org/c/coreboot/+/41098/comment/49d802ca_63694d14 PS2, Line 7: * ACPI message indicator.
Dot at the end not needed?
Gone
https://review.coreboot.org/c/coreboot/+/41098/comment/34a0272c_28724b1f PS2, Line 33: /*SLST = Arg0*/
Add spaces around the comment characters?
Done
https://review.coreboot.org/c/coreboot/+/41098/comment/b8f7a287_6d3a191b PS2, Line 63: Return(Package(0x02){0x00, 0x00})
Add a space at least before {?
Done
File src/mainboard/asus/p2b/suspend.asl:
https://review.coreboot.org/c/coreboot/+/41098/comment/4eeb8340_0355ab2b PS4, Line 2: /* This file is part of the coreboot project. */
please remove
Gone
File src/mainboard/asus/p2b/variants/p3b-f/suspend.asl:
https://review.coreboot.org/c/coreboot/+/41098/comment/2be666bd_08267044 PS2, Line 169: * Prepare To Sleep,
Remove , at the end?
Gone
https://review.coreboot.org/c/coreboot/+/41098/comment/14b689fc_25367fbb PS2, Line 175: SLST = Arg0
No idea if Firefox/Gerrit is broken, but there are no tabs shown here for indentation. […]
Done
File src/mainboard/asus/p2b/variants/p3b-f/suspend.asl:
https://review.coreboot.org/c/coreboot/+/41098/comment/3708aa37_7948b125 PS4, Line 2: * This file is part of the coreboot project. *
please remove
Gone
https://review.coreboot.org/c/coreboot/+/41098/comment/cd325a43_ee8cf2bd PS4, Line 35: Store
you used ASL2. […]
Done
File src/mainboard/asus/p2b/variants/p3b-f/suspend.asl:
https://review.coreboot.org/c/coreboot/+/41098/comment/3d215b11_d267f036 PS6, Line 217: Method (_MSG, 1, NotSerialized)
AAAAA! Spaces!
Done
https://review.coreboot.org/c/coreboot/+/41098/comment/daca8a65_bd859940 PS6, Line 232:
double blank line
Done