Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30902 )
Change subject: mistral: qcs405: Updated the layout info as in Gale ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/#/c/30902/5/src/mainboard/google/mistral/chromeo... File src/mainboard/google/mistral/chromeos.fmd:
https://review.coreboot.org/#/c/30902/5/src/mainboard/google/mistral/chromeo... PS5, Line 7: GBB@0x301000 0xdef00 we should be able to make this smaller. for example, cheza uses a size of 0x2f00
https://review.coreboot.org/#/c/30902/5/src/mainboard/google/mistral/chromeo... PS5, Line 20: RW_GPT@0x560000 0x20000 { The GPT is necessary so the boot ROM can boot from SPI? How does the boot ROM find the GPTs, fixed offsets? In any case, if the GPT is necessary to look up the bootblock, it needs to be in the RO part of the flash.